Add support for Humble #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebedard
requested review from
lihui815 and
jhdcs
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
=======================================
Coverage 49.61% 49.61%
=======================================
Files 2 2
Lines 262 262
Branches 68 68
=======================================
Hits 130 130
Misses 132 132
Continue to review full report at Codecov.
|
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
…Jammy Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
christophebedard/add-support-for-humble
branch
from
06589eb
to
c2a8414
Compare
|
@ijnek would you mind reviewing this PR as well? 😁 |
ijnek
suggested changes
May 2, 2022
Co-authored-by: Kenji Brameld <kenjibrameld@gmail.com> Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
christophebedard/add-support-for-humble
branch
from
1392af7
to
b769ad2
Compare
ijnek
approved these changes
May 2, 2022
|
Looks like GitHub does not yet have Ubuntu 22.04 runners. |
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
|
The last change looks fine to me |
|
thanks for the review @ijnek! |
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #738
This adds support for Humble by adding it to the list of valid distros. I've updated the tests.
I didn't update the examples in the README since Humble has not yet been officially released, so users need to use the testing repository.
Signed-off-by: Christophe Bedard bedard.christophe@gmail.com