Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lint job to separate workflow file and check build artifact #774

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

christophebedard
Copy link
Member

Copied from setup-ros: https://github.com/ros-tooling/setup-ros/blob/57bc9dc0ed672890441ae4fe26e55542b3920506/.github/workflows/pr.yml.

It's quite useful to make sure the dist/index.js file has been generated.

Signed-off-by: Christophe Bedard christophe.bedard@apex.ai

@christophebedard christophebedard requested a review from a team as a code owner September 12, 2022 23:45
@christophebedard christophebedard self-assigned this Sep 12, 2022
@christophebedard christophebedard requested review from emersonknapp and Karsten1987 and removed request for a team September 12, 2022 23:45
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #774 (f7330b9) into master (9ca5b23) will decrease coverage by 1.11%.
The diff coverage is n/a.

❗ Current head f7330b9 differs from pull request most recent head 94c4d42. Consider uploading reports for the commit 94c4d42 to get more accurate results

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
- Coverage   50.00%   48.88%   -1.12%     
==========================================
  Files           2        2              
  Lines         268      268              
  Branches       72       72              
==========================================
- Hits          134      131       -3     
- Misses        134      137       +3     
Impacted Files Coverage Δ
src/action-ros-ci.ts 42.67% <0.00%> (-1.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard merged commit 78375ce into master Sep 13, 2022
@christophebedard christophebedard deleted the christophebedard/check-build-file branch September 13, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant