Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force exit from main thread on signal handling in keyboard_handler #23

Merged

Conversation

MichaelOrlov
Copy link
Member

@MichaelOrlov MichaelOrlov commented Sep 8, 2022

Trigger internal exit variable to true from signal handler in keyboard handler to avoid getting stuck on next read function after changing input mode to the canonical i.e. required to press Enter.

@MichaelOrlov MichaelOrlov self-assigned this Sep 8, 2022
@MichaelOrlov
Copy link
Member Author

@clalancette I am getting a strange error on CI which is relates to the build infrastructure and I don't know how to resolve it.
Aka No definition of [ament_cmake] for OS version [focal]

[command]/usr/bin/bash -c ./install_rosdeps.sh rolling
2022-09-08T02:52:55.7113542Z + '[' 1 '!=' 1 ']'
2022-09-08T02:52:55.7113792Z + DISTRO=rolling
2022-09-08T02:52:55.7118605Z ++ colcon list --paths-only --packages-up-to keyboard_handler
2022-09-08T02:52:56.4967304Z + package_paths=src/528x5nw73ng/keyboard_handler/keyboard_handler
2022-09-08T02:52:56.4968368Z + rosdep install -r --from-paths src/528x5nw73ng/keyboard_handler/keyboard_handler --ignore-src --skip-keys 'rti-connext-dds-5.3.1 ' --rosdistro rolling -y
2022-09-08T02:52:57.2743560Z ERROR: the following packages/stacks could not have their rosdep keys resolved
2022-09-08T02:52:57.2743980Z to system dependencies:
2022-09-08T02:52:57.2744367Z keyboard_handler: No definition of [ament_cmake] for OS version [focal]
2022-09-08T02:52:57.2744757Z Continuing to install resolvable dependencies...
2022-09-08T02:52:57.2750487Z #All required rosdeps installed successfully

Is it known problem?
I found reference to the old similar problem ros-navigation/navigation2#2813 but have no idea how to fix this error in my case with keyboard_handler package.

@clalancette
Copy link
Contributor

Aka No definition of [ament_cmake] for OS version [focal]

It's a problem in the GitHub Action for this repository. In short, Rolling no longer targets focal, it targets jammy, so you'll need to update

image: rostooling/setup-ros-docker:ubuntu-focal-latest
to point to jammy instead.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov force-pushed the morlov/force_exit_form_main_thread_on_signal_handling branch from ef37905 to 09cd3cd Compare September 9, 2022 01:13
@MichaelOrlov MichaelOrlov marked this pull request as ready for review September 9, 2022 02:51
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner September 9, 2022 02:51
@MichaelOrlov MichaelOrlov requested review from gbiggs, Karsten1987 and emersonknapp and removed request for a team and Karsten1987 September 9, 2022 02:51
@MichaelOrlov
Copy link
Member Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/61bc8c1b0e80092b6efc3098428564f5/raw/ed274df52a0fa8442503a4959f39b58643bcb654/ros2.repos
BUILD args: --packages-above-and-dependencies keyboard_handler
TEST args: --packages-above keyboard_handler
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10778

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Member Author

Warning on Windows build is known issue existing on baseline and will be handled in ros2/rosbag2#1084
Test failure on Linux build also a know issue and unrelated to the changes from this PR.

@MichaelOrlov MichaelOrlov merged commit 039f270 into rolling Sep 10, 2022
@MichaelOrlov
Copy link
Member Author

https://github.com/Mergifyio backport humble

mergify bot pushed a commit that referenced this pull request Sep 10, 2022
…23)

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 039f270)
@mergify
Copy link

mergify bot commented Sep 10, 2022

backport humble

✅ Backports have been created

MichaelOrlov added a commit that referenced this pull request Sep 29, 2022
…23) (#25)

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 039f270)

Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
@clalancette clalancette deleted the morlov/force_exit_form_main_thread_on_signal_handling branch July 24, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants