Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of the sip_configure.py file. #131

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Cleanup of the sip_configure.py file. #131

merged 1 commit into from
Dec 8, 2023

Conversation

clalancette
Copy link
Contributor

This is to do 2 main things:

  1. Move away from distutils.find_executable, which is deprecated.
  2. Take a bunch of error handling out of an exception handler. This just makes the code easier to follow if another exception occurs.

@clalancette
Cleanup of the sip_configure.py file.
564782f 
This is to do 2 main things:

1.  Move away from distutils.find_executable, which is deprecated.
2.  Take a bunch of error handling out of an exception handler.
    This just makes the code easier to follow if another exception
    occurs.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit ee4d43b into rolling Dec 8, 2023
2 checks passed
@clalancette clalancette deleted the clalancette/sip-cleanup branch December 8, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @mjcarroll