Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[melodic] Adding SIP 5 integration. #94

Open
wants to merge 1 commit into
base: melodic-devel
Choose a base branch
from

Conversation

seanyen
Copy link

@seanyen seanyen commented Aug 7, 2020

This is an attempt to implement SIPv5 integration. Since SIPv5, it started to implement PEP 517 compliant backend and stopped releasing sipconfig module.

To integrate with it, one can define PEP 518 (a.k.a., pyproject.toml) project file to describe the SIP build. And here are the minimum requirement to run:

And here is some highlights of my verification environment:

  • Windows 10
  • Python 3.8.3 (pip-20.2.1, setuptools-49.2.1)
  • Qt5 5.15.0 (Vcpkg port)
  • Installed python modules:
PyQt-builder==1.4.0
PyQt5==5.15.0
PyQt5-sip==12.8.0
sip==5.3.0

@dirk-thomas
Copy link
Contributor

Can you please provide some more context: e.g. what minimum version of sip / setuptools is required for this patch to work, if you have verified this still work on e.g. Ubuntu with the Debian packages or with a newer version of SIP, etc.

@seanyen
Copy link
Author

seanyen commented Aug 8, 2020

@dirk-thomas I tried to capture the minimum requirements specified on the book (also added more matrix on Windows side). For the Linux validation, I found it is little bit tricky to have a system with Qt>=5.14 plus all other Python required modules. Please excuse my limited knowledge on Linux side, do you just happen to know what distro \ release I can begin with first to get a closer environment?

@jspricke
Copy link
Contributor

@seanyen Debian unstable/testing has all the packages in the required versions.

@sloretz
Copy link
Contributor

sloretz commented Jul 21, 2021

@seanyen Is this PR still relevant after #95 and #105?

@lopsided98
Copy link
Contributor

I think this PR is still required to build python_qt_binding with SIP >=5. SIP 4 is currently still required to build this package, those other PRs just allow this package to work in combination with PyQt5 built with SIP >=5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants