qt_gui: use native default icon theme if suitable #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ros-pull-request-builder retest this please |
|
Thanks for the patch. The Noetic CI can be ignored - it will be resolved by #201. |
dirk-thomas
pushed a commit
that referenced
this pull request
Mar 2, 2020
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
qt_guichecks ifQIcon::themeName()is empty and, if that is the case, proceeds to setTangoas the icon theme. However,QIcon::themeName()can be empty, meaning "use the system default theme". This PR simply removes this check. If there is any motivation for the check I'm not aware of, please disregard.On my system (KDE), this allows rqt to use the native icon theme (Breeze), resulting in a much more integrated look and feel.
We still have the other checks that make sure important icons are available.
This might also solve problems on Mac & Windows (#154), where Tango is not available, but I don't know if there is any default icon theme there.