Disable reading from bag while recording - use direct caching to index for timeline #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x for timeline Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
mjeronimo
approved these changes
Sep 2, 2022
|
@ivanpauno do you have any opinion on this? |
|
Seems like a fair tradeoff to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121
RFC: This covers the Recording functionality for #121. Draft PR for consideration, feeling out opposition on whether the proposed tradeoff is acceptable.
Description
Rosbag2 doesn't actually support reading-while-writing. The current code goes around this limitation by making queries directly into the SQLite database, but MCAP is now growing in usage as a rosbag2 storage format, so we need rqt_bag to support strictly the rosbag2 API.
For now, I believe it is a worthwhile tradeoff to lose the RawView/PlotView on bags currently recording, in order to gain support for all storage implementations. From what I can tell, the PlotView only shows "data-until-now" when opened, and cannot refresh data, so the panel needs to be closed and reopened to see new data. RawView likewise does not update while recording, since the playhead does not advance - though the user can click in.