Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience launch file for rqt_bag #440

Closed
wants to merge 1 commit into from

Conversation

lucasw
Copy link
Contributor

@lucasw lucasw commented Mar 3, 2017

It's useful to have a simple launch wrapper for rqt_bag so that it is automatic to get a roscore running if there isn't one running already - for example getting rqt_bag associated with *.bag file in Ubuntu: http://answers.ros.org/question/256044/open-bags-in-rqt_bag-in-by-clicking-on-one-in-ubuntu/

This a workaround for #238

I notice there are no other launch files in here other than test/test.launch, I couldn't say if adding this one implies every plugin here ought to have one like this.

@dirk-thomas
Copy link
Contributor

I would say it only makes sense to add launch files for plugins which are commonly started "standalone" (without running a roscore). For rqt_bag that is certainly the case so look at recorded bags.

Thank you for the contribution. I have cherry-picked your patch and added the missing install rule in 6d9fdf5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants