Fix compile error due to the user-defined string literals feature #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more time then: Note that GCC 6 compiles with C++11 support enabled by default, so this is required to compile rviz from source on for example Arch Linux. Since this is also true for the inidigo version, I think it is a good idea to backport it to indigo-devel. |
|
👍 I added the patch to the PKGBUILD for now. |
bchretien
added a commit
to bchretien/arch-ros-stacks
that referenced
this pull request
May 22, 2016
bchretien
added a commit
to bchretien/arch-ros-stacks
that referenced
this pull request
May 22, 2016
de-vri-es
pushed a commit
to fizyr-forks/rviz
that referenced
this pull request
May 28, 2016
wjwwood
pushed a commit
that referenced
this pull request
Jun 16, 2016
130s
pushed a commit
to 130s/rviz
that referenced
this pull request
Aug 21, 2024
* Added Effort plugin Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit e3b56ed7058502d94fe3d1c27948d4f4e9be58a8) Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While compiling rviz from source on Arch with gcc 6.1.1, got errors like the following:
In file included from /opt/ros/kinetic/include/tf/transform_datatypes.h:44:0, from /opt/ros/kinetic/include/tf/time_cache.h:38, from /opt/ros/kinetic/include/tf/tf.h:43, from /opt/ros/kinetic/include/tf/transform_listener.h:38, from [..]/src/rviz/src/rviz/default_plugin/effort_display.cpp:4: [..]/src/rviz/src/rviz/default_plugin/effort_display.h: In destructor ‘virtual tf::MessageFilterJointState::~MessageFilterJointState()’: [..]/src/rviz/src/rviz/default_plugin/effort_display.h:39:37: error: unable to find string literal operator ‘operator""fmt’ with ‘const char [28]’, ‘long unsigned int’ arguments ROS_DEBUG_NAMED("message_filter", "MessageFilter [target=%s]: "fmt, getTargetFramesString().c_str(), __VA_ARGS__) ^With the new C++11 user-defined string literals feature, there has to be a space between string concatenations like the ones used here. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51282.