add option to disable keyboard focus being set on mouse move #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently all mouse events get forwarded to onRenderWindowMouseEvents, there keyboard focus is requested (setFocus) unconditionally. This commit adds a new property "focus_on_mouse_move_" that enables setting keyboard focus on mouse move events. Setting focus on click or wheel is handled by QObject::setFocusPolicy Subclasses/Users of rvis::RenderPanel can disable either setting focus on mouse move by using the boolean property and disable keyboard focus on click, on wheel or totally via setFocusPolicy
|
ping? |
|
thanks for the PR, we'll take a look at it as soon as possible |
|
Since this is an ABI breaking change I had to target to the |
ghost
assigned 
wjwwood
approved these changes
May 10, 2018
|
@simonschmeisser if you want/need this in |
|
@wjwwood thanks for merging it to melodic. I'm fine that way. We will upgrade asap anyway and have a workaround for the time being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently all mouse events get forwarded to onRenderWindowMouseEvents,
there keyboard focus is requested (setFocus) unconditionally. This commit
adds a new property "focus_on_mouse_move_" that enables setting keyboard
focus on mouse move events. Setting focus on click or wheel is handled by
QObject::setFocusPolicy
Subclasses/Users of rvis::RenderPanel can disable either setting focus on
mouse move by using the boolean property and disable keyboard focus on click,
on wheel or totally via setFocusPolicy