Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rviz segfaults on pointclou2 with new opengl #1584

Closed
koniarik opened this issue Feb 5, 2021 · 11 comments · Fixed by #1588
Closed

rviz segfaults on pointclou2 with new opengl #1584

koniarik opened this issue Feb 5, 2021 · 11 comments · Fixed by #1588
Labels
bug opengl

Comments

@koniarik
Copy link

koniarik commented Feb 5, 2021

Got segfault with pointcloud2 view from realsense camera.
Everytime I try to enable the plugin for it and receive data (works in case it has no topic), rviz immediatly segfaults.

Everything works just OK with '--opengl 210'.

Your environment
@rhaschke
Copy link
Contributor

rhaschke commented Feb 6, 2021

This seems similar to #1508, but in your case an AMD GPU is affected. Can you provide the output of glxinfo | grep OpenGL please?

@koniarik
Copy link
Author

koniarik commented Feb 6, 2021

sure:

➜ glxinfo | grep OpenGL
OpenGL vendor string: AMD
OpenGL renderer string: AMD RAVEN (DRM 3.38.0, 5.8.0-41-generic, LLVM 11.0.1)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 20.3.4 - kisak-mesa PPA
OpenGL core profile shading language version string: 4.60
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
OpenGL core profile extensions:
OpenGL version string: 4.6 (Compatibility Profile) Mesa 20.3.4 - kisak-mesa PPA
OpenGL shading language version string: 4.60
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile
OpenGL extensions:
OpenGL ES profile version string: OpenGL ES 3.2 Mesa 20.3.4 - kisak-mesa PPA
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20
OpenGL ES profile extensions:

@rhaschke
Copy link
Contributor

rhaschke commented Feb 8, 2021

I have pushed a new commit to melodic-devel to have rviz report the employ rendering device during startup.
Could you please build the latest melodic-devel branch please from source and report this new information?
I'm surprised, that rviz doesn't automatically downgrade to an older OpenGL version, because we know that the Mesa libs have issues rendering rviz' more modern material scripts.

@koniarik
Copy link
Author

koniarik commented Feb 9, 2021

I tried to just compile it localy in workspace, btu got an error:

/home/veverak/Projects/Schpin/repos/thirdparty/rviz/src/rviz/default_plugin/interactive_marker_display.cpp:122:100: error: no matching function for call to ‘interactive_markers::InteractiveMarkerClient::InteractiveMarkerClient(tf::Transformer&, std::string)’

using everything as packages from repository, any tips how to make this?

@rhaschke
Copy link
Contributor

rhaschke commented Feb 9, 2021

This looks like a mismatch between Melodic and Noetic. Which system are you compiling on? Which branch did you checkout?

@koniarik
Copy link
Author

My mistake, I am no noetic, completely forgot about that

@koniarik
Copy link
Author

SO, I applied the patch on noetic version which I am using (again, sorrt for that):

[ INFO] [1613002034.041585762]: rviz version 1.14.4
[ INFO] [1613002034.041681030]: compiled against Qt version 5.12.8
[ INFO] [1613002034.041716486]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1613002034.062530782]: Forcing OpenGl version 0.
[ INFO] [1613002034.436060548]: Stereo is NOT SUPPORTED
[ INFO] [1613002034.436311486]: OpenGL device: AMD RAVEN (DRM 3.38.0, 5.8.0-43-generic, LLVM 11.0.1)
[ INFO] [1613002034.436391325]: OpenGl version: 4,6 (GLSL 4,6).

@rhaschke
Copy link
Contributor

Thanks for the feedback. Could you please insert the following line of code:

std::cerr << glGetString(GL_VENDOR) << " - " << glGetString(GL_RENDERER) << " - " << glGetString(GL_VERSION) << std::endl;

into the function RenderSystem::detectGlVersion such that this info is printed on startup as well?

rviz/src/rviz/ogre_helpers/render_system.cpp

Line 170 in c36e265

void RenderSystem::detectGlVersion()

@koniarik
Copy link
Author

AMD - AMD RAVEN (DRM 3.38.0, 5.8.0-43-generic, LLVM 11.0.1) - 4.6 (Compatibility Profile) Mesa 20.3.4 - kisak-mesa PPA

rhaschke added a commit to rhaschke/rviz that referenced this issue Feb 11, 2021
@rhaschke
Enforce GLSL 1.4 on more Mesa systems (ros-visualization#1559)
4522564 
Same problem showed up on AMD GPU: ros-visualization#1584.
@rhaschke rhaschke mentioned this issue Feb 11, 2021
Merged
@rhaschke
Copy link
Contributor

Everything works just OK with '--opengl 210'.

@SquirrelCZE, could you please check whether '--opengl 310' resolves the segfault as well?

@rhaschke rhaschke mentioned this issue Feb 17, 2021
Closed
@rhaschke
Copy link
Contributor

Dear @SquirrelCZE,
could you please confirm whether you face #1508 (comment) as well on your AMD hardware? I filed an issue on Mesa for that and they are wondering which type of hardware is affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug opengl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce GLSL 1.4 on more Mesa systems (#1559) rhaschke/rviz
2 participants
@rhaschke @koniarik