Make read-only properties read-only #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea how this relates to #687? |
|
lgtm I was able to reproduce by using the |
wjwwood
added a commit
that referenced
this pull request
Feb 26, 2016
Make read-only properties read-only
130s
pushed a commit
to 130s/rviz
that referenced
this pull request
Aug 21, 2024
* Update Frame shortcut Signed-off-by: David V. Lu <davidvlu@gmail.com> (cherry picked from commit 5eeae5b12e73b17f735ce62630b4ebf15c5f423e) Co-authored-by: David V. Lu!! <davidvlu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A read-only property shouldn't be allowed to be edited ;-)
Fixed by not creating an editor in that case.
Related #654 which attempted to solve that issue by disabling the property,
which in turn was reverted in #679 due to its side effects.