Add fullscreen option. #1017

de-vri-es · 2016-05-29T21:38:58Z

This PR adds an option to enter fullscreen mode, hiding all interface elements and showing nothing but the rendered view. It makes rviz much nicer to use for showing information in demo setups.

I added the option under the view_menu_ in code, but it turns out it's actually called "Panels" in the GUI. That might make it the wrong place for this option. Alternatively the menu could be renamed to view, or a new view menu could be added.

F11 also works, and is the only way other than restarting rviz to leave fullscreen mode. Might make sense to also use Escape for that?

One point of note: I'm using setHideButtonVisibility(bool) which is a public member of VisualizationFrame. I couldn't find anything actually calling the member, but if it is exposed to plugins they could potentially interact badly with the fullscreen option. It seems unlikely though, so maybe it's better to make that member private?

de-vri-es · 2016-05-29T21:41:51Z

Oh, I tested on a system runing xmonad without window decorations, so I'm not 100% that showFullScreen() removes the window decoration. I kind of assumed it does.

de-vri-es · 2016-06-03T20:41:32Z

Updated to use signals/slot for notifying PanelDockWidgets of full screen changes to decouple them from the VisualizationFrame again.

VictorLamoine · 2016-08-31T13:14:54Z

I tested this PR and it works perfectly. Escape allows to exit the full screen mode.

Minor issue: the maximized window state is not retrieved when exiting full screen (the window is not maximized anymore).

Really useful for demos/screenshots.

👍

de-vri-es · 2016-08-31T13:18:30Z

I'll see if there is a sensible way to retain maximized state. Thanks for testing!

de-vri-es · 2016-09-16T12:55:04Z

By the way, escape does work to exit full screen mode.

wjwwood · 2016-10-17T20:04:41Z

Did you ever find a way to preserve the maximized state?

VictorLamoine · 2016-10-17T20:25:48Z

src/rviz/visualization_frame.h

@@ -350,6 +358,9 @@ protected Q_SLOTS:
  ros::WallTime last_fps_calc_time_;

  QString error_message_; ///< Error message (if any) from most recent saveDisplayConfig() call.
+
+  /// Indicates if the toolbar should be visible outside of fullscreen mode.
+  bool toolbar_visibile_;


Typo, visible

Thanks btw, fixed.

VictorLamoine · 2016-10-17T20:35:11Z

1 - Retrieve if the window was maximized before going full screen
2 - When returning from full screen, call showMaximized instread of showNormal if the window was maximized before.

The problem is that the maximized property does not work with X11. I tested and it is always zero, it is stated in Qt docs (see above links).

void VisualizationFrame::setFullScreen( bool full_screen )
{
  Q_EMIT( fullScreenChange( full_screen ) );
  static bool was_maximized( isMaximized() );

  if (full_screen)
    toolbar_visibile_ = toolbar_->isVisible();
  else
    was_maximized = isMaximized();

  std::cout << was_maximized << std::endl;

  menuBar()->setVisible(!full_screen);
  toolbar_->setVisible(!full_screen && toolbar_visibile_);
  statusBar()->setVisible(!full_screen);
  setHideButtonVisibility(!full_screen);

  if (full_screen)
    showFullScreen();
  else if (was_maximized)
    showMaximized();
  else
    showNormal();
}

de-vri-es · 2016-10-18T08:26:36Z

There's also QtWidget::saveGeometry() and QtWidget::restoreGeometry(). Not sure how reliable that will be, but it's worth a try. Note that I'm currently on holiday, so earliest I can try it is somewhere next week.

VictorLamoine · 2016-10-19T21:02:20Z

Fixes #743

de-vri-es · 2017-01-10T15:17:41Z

Digging through the Qt documentation once more, I found this method of setting/disabling fullscreen:

if (full_screen)
  setWindowState(windowState() | Qt::WindowFullScreen);
else
  setWindowState(windowState() & ~Qt::WindowFullScreen);
show();

This preserves all other flags such as minimized (not applicable here I think) and maximized state. I tested with a xfwm4 as window manager, and it worked as expected. Window state is preserved between entering and leaving fullscreen.

Updated and rebased the PR.

But note that I don't think it fixes #743. All widgets except for the 3D display are hidden in full-screen mode. That probably includes camera displays.

wjwwood · 2017-01-10T20:03:39Z

Cool, I'll have another pass at it asap.

de-vri-es · 2017-02-27T22:47:27Z

No rush, I haven't been rushing either, but have you had the time already?

wjwwood · 2017-02-27T22:50:43Z

I'll come around to it before the Lunar release of rviz.

de-vri-es · 2017-02-27T22:52:56Z

Heh, shooting for the moon. Anyway, thanks :)

VictorLamoine · 2017-03-02T13:50:52Z

I tested again and it still works great.

The issue with the full-screen mode not being kept is still here but does not happen the first time. I think this really is minor and should not prevent the merging of this PR.

Here is a nice video:
https://drive.google.com/open?id=0B4_0QfSy1tFqa29fMHZCTWwxbHc

de-vri-es · 2017-03-05T09:50:58Z

The issue with the full-screen mode not being kept is still here but does not happen the first time. I think this really is minor and should not prevent the merging of this PR.

That is weird. I tested with xfwm and the previous version did mess up maximized state after leaving full screen, but the current did not.

Though I agree its something that shouldn't be a big problem for merging. Since it's a problem with Qt / X11 I actually think it's better to ignore it. The proper place to fix it is there. Any workaround we introduce may end up breaking if Qt fixes the issue on their end, and we end up with legacy code which nobody really remembers the purpose of.

wjwwood

changes lgtm

wjwwood · 2017-05-01T19:45:30Z

Finally got around to testing this. Looks good, thanks!

wxmerkt · 2017-05-01T20:44:34Z

Awesome, thanks! Will this be backported to indigo and released into the debians?

wjwwood · 2017-05-01T21:12:49Z

@wxmerkt I was just going to put it into Kinetic and Lunar, but since you asked nicely (and it seems low risk) I'll back port it to Indigo too.

de-vri-es · 2017-05-01T21:23:33Z

hmm, maybe I shouldn't have removed the branch? Yay, github has a restore branch button.

Thanks for merging.

wjwwood · 2017-05-02T00:28:23Z

@de-vri-es that's ok, I'll manually handle cherry-picking for forward/back porting.

wxmerkt · 2017-05-02T07:47:47Z

Thank you @wjwwood :)

wjwwood · 2017-06-05T22:10:04Z

Backported in #1110

* Add fullscreen option. (#1017) * urdfdom compatibility (#1064) * Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package * Update display if empty pointcloud2 is published (#1073) Do not show last point cloud any more, if published point cloud message does not contain any points * Correctly scale the render panel on high resolution displays (#1078) * support multiple material for one link (#1079) * Fixed duplicate property name for Path colors (#1089) See issue #1087. * fix type error in newer versions of urdf (#1098) * Use unique material names for robot links. (#1102) * avoid C++11 feature for back port to indigo

de-vri-es force-pushed the kinetic-fullscreen branch 2 times, most recently from c0fc365 to 77663df Compare June 3, 2016 20:40

wjwwood added the enhancement label Oct 17, 2016

wjwwood added this to the untargeted milestone Oct 17, 2016

VictorLamoine reviewed Oct 17, 2016

View reviewed changes

de-vri-es force-pushed the kinetic-fullscreen branch from 77663df to 4cf71ad Compare January 10, 2017 15:11

Add fullscreen option.

6805749

de-vri-es force-pushed the kinetic-fullscreen branch from 4cf71ad to 6805749 Compare April 7, 2017 08:50

wjwwood approved these changes May 1, 2017

View reviewed changes

wjwwood merged commit fae736d into ros-visualization:kinetic-devel May 1, 2017

wjwwood added the needs back port label May 1, 2017

de-vri-es deleted the kinetic-fullscreen branch May 1, 2017 21:18

de-vri-es restored the kinetic-fullscreen branch May 1, 2017 21:23

wxmerkt pushed a commit to wxmerkt/rviz that referenced this pull request May 25, 2017

Add fullscreen option. (ros-visualization#1017)

72f8270

wxmerkt mentioned this pull request May 25, 2017

Add fullscreen option (backport #1017 to indigo) #1108

Closed

wjwwood removed the needs back port label Jun 5, 2017

wjwwood pushed a commit that referenced this pull request Jun 5, 2017

Add fullscreen option. (#1017)

bc36298

wjwwood mentioned this pull request Jun 5, 2017

indigo-devel backports from kinetic-devel (1.12.9) #1110

Merged

rhaschke mentioned this pull request Sep 2, 2019

Esc shortcut to leave fullscreen prevents canceling tools from working #1257

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fullscreen option. #1017

Add fullscreen option. #1017

de-vri-es commented May 29, 2016

de-vri-es commented May 29, 2016

de-vri-es commented Jun 3, 2016

VictorLamoine commented Aug 31, 2016 •

edited

Loading

de-vri-es commented Aug 31, 2016

de-vri-es commented Sep 16, 2016

wjwwood commented Oct 17, 2016

VictorLamoine Oct 17, 2016

de-vri-es Jan 11, 2017

VictorLamoine commented Oct 17, 2016 •

edited

Loading

de-vri-es commented Oct 18, 2016

VictorLamoine commented Oct 19, 2016

de-vri-es commented Jan 10, 2017

wjwwood commented Jan 10, 2017

de-vri-es commented Feb 27, 2017

wjwwood commented Feb 27, 2017

de-vri-es commented Feb 27, 2017

VictorLamoine commented Mar 2, 2017

de-vri-es commented Mar 5, 2017

wjwwood left a comment

wjwwood commented May 1, 2017

wxmerkt commented May 1, 2017

wjwwood commented May 1, 2017

de-vri-es commented May 1, 2017

wjwwood commented May 2, 2017

wxmerkt commented May 2, 2017

wjwwood commented Jun 5, 2017

Add fullscreen option. #1017

Add fullscreen option. #1017

Conversation

de-vri-es commented May 29, 2016

de-vri-es commented May 29, 2016

de-vri-es commented Jun 3, 2016

VictorLamoine commented Aug 31, 2016 • edited Loading

de-vri-es commented Aug 31, 2016

de-vri-es commented Sep 16, 2016

wjwwood commented Oct 17, 2016

VictorLamoine Oct 17, 2016

Choose a reason for hiding this comment

de-vri-es Jan 11, 2017

Choose a reason for hiding this comment

VictorLamoine commented Oct 17, 2016 • edited Loading

de-vri-es commented Oct 18, 2016

VictorLamoine commented Oct 19, 2016

de-vri-es commented Jan 10, 2017

wjwwood commented Jan 10, 2017

de-vri-es commented Feb 27, 2017

wjwwood commented Feb 27, 2017

de-vri-es commented Feb 27, 2017

VictorLamoine commented Mar 2, 2017

de-vri-es commented Mar 5, 2017

wjwwood left a comment

Choose a reason for hiding this comment

wjwwood commented May 1, 2017

wxmerkt commented May 1, 2017

wjwwood commented May 1, 2017

de-vri-es commented May 1, 2017

wjwwood commented May 2, 2017

wxmerkt commented May 2, 2017

wjwwood commented Jun 5, 2017

VictorLamoine commented Aug 31, 2016 •

edited

Loading

VictorLamoine commented Oct 17, 2016 •

edited

Loading