Clang tidy fixes

[esteve]

This PR fixes some issues that clang-tidy detected.

[esteve]

That's weird, the lunar job failed, but the other ones pass. @mikaelarguedas is that expected or should I look into it? Thanks!

[mikaelarguedas]

@esteve This test is flaky so the failure is not due to this PR.

Thanks for the contribution!

[esteve]

@mikaelarguedas thanks for the prompt response! clang-tidy has some other suggestions, but they might involve C++11. Given that Kinetic requires a C++11-capable compiler, would you be ok if I submitted those contributions for review? They don't change the API in any way and keeps it C++03, they are just fixes/improvements to some internal stuff, but it'd mean creating a new kinetic-devel branch to avoid introducing C++11 in Indigo.

[mikaelarguedas]

lgtm, thanks @esteve, will merge this once other PRs are merged and will resolve conflicts on this one.

[esteve]

@mikaelarguedas no problem, let me know if I can help somehow (resolving conflicts or otherwise) and if I should submit any clang-tidy fixes that use C++11 after all the other PRs are merged

[mikaelarguedas]

@mikaelarguedas thanks for the prompt response! clang-tidy has some other suggestions, but they might involve C++11. Given that Kinetic requires a C++11-capable compiler, would you be ok if I submitted those contributions for review?

I'm considering branching out actionlib for lunar to be able to do some code cleanup and some changes that may change behavior (while being mostly style + bug fixes). I could extend this to kinetic if it make sense for such improvements.

A few things to consider given that I don't know how spread your changes can be:

• according to where the changes lie, using c++11 may require downstream packages to pass the -std=c++11 flag. I think that's something we'd like to avoid in general so that every package consuming this one doesn't have to change it's cmake. Given your remark "They don't change the API in any way and keeps it C++03", I think we should be safe on that front.
• I opened a fix most cpplint and uncrustify errors #72 some time ago to fix mostly style and that I was thinking of integrating to the to be created dev branch. Once merged it may conflict with the changes you will submit.