Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simple_action_server.py] Set auto_start to false by default. #60

Closed
wants to merge 1 commit into from

Conversation

130s
Copy link
Member

@130s 130s commented Dec 11, 2016

In this QA it's explained (by @mirzashah) how bad auto_start=True could be. So I thought to turn that to False.

However because this could break existing application I don't think we should apply this change. I'm still sending this PR to ask for a confirmation.

@mikaelarguedas
Copy link
Member

Thanks @130s for the link to the discussion.
Although the default is not optimal I agree with you that changing the default could break applications relying on the simple action server.

I'd prefer to keep the same default values in ActionServer and SimpleActionServer so I won't merge this to keep consistency and avoid breakage. I think that is why there is a warning in ActionServer rather than a different default.

It's nevertheless not great to have different defaults in the c++ and Python implementations...

We can revisit this decision in the future if we decide that consistency and recommended defaults overweight the downside of potential breakage

Thanks for pointing it out!

@130s
Copy link
Member Author

130s commented Jul 4, 2018

Thanks for clarification @mikaelarguedas.

I've added a note on one of the tutorials I found, to raise more attention. Not sure if that's the only place to be updated though, but I hope that's enough to at least close this wontfix PR.

@130s 130s closed this Jul 4, 2018
@130s 130s deleted the impr/py_autostart branch July 4, 2018 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants