Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using CATKIN_ENABLE_TESTING to optionally configure tests #10

Closed
wants to merge 1 commit into from

Conversation

bulwahn
Copy link

@bulwahn bulwahn commented Jul 3, 2013

Since ff60599b8077b86a6d75d510da72e69899d16008 in the catkin
repository, catkin provides means to optionally configure tests.
This commit adjusts the CMakeLists.txt to opt-in the tests.

This commit is currently needed for cross-compiling class-loader
(without tests) in the meta-ros project (github.com/bmwcarit/meta-ros)
without requiring gtest. Details are found at
ros/meta-ros#86.

Signed-off-by: Lukas Bulwahn lukas.bulwahn@oss.bmw-carit.de

Since ff60599b8077b86a6d75d510da72e69899d16008 in the catkin
repository, catkin provides means to optionally configure tests.
This commit adjusts the CMakeLists.txt to opt-in the tests.

This commit is currently needed for cross-compiling class-loader
(without tests) in the meta-ros project (github.com/bmwcarit/meta-ros)
without requiring gtest. Details are found at
ros/meta-ros#86.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
@dirk-thomas
Copy link
Member

This patch must also specify a versioned dependency on catkin to make sure that catkin supports this. That will be the upcoming 0.5.68.

<buildtool_depend version_gte="0.5.68">catkin</buildtool_depend>

dirk-thomas added a commit that referenced this pull request Jul 3, 2013
severin-lemaignan referenced this pull request in severin-lemaignan/robotpkg Aug 18, 2014
Changes since 0.1.29:
0.3.0 (2014-06-25)
------------------
* Use system-provided console-bridge
* Contributors: Esteve Fernandez

0.2.5 (2014-03-04)
------------------
* Changed format of debug messages so that rosconsole_bridge can correctly
parse the prefix
* Improved debug output

0.2.4 (2014-02-12)
------------------
* fix race condition with multi threaded library loading (`#16
<https://github.com/ros/class_loader/issues/16>`_)

0.2.3 (2013-08-21)
------------------
* fix missing class name in logWarn output

0.2.2 (2013-07-14)
------------------
* check for CATKIN_ENABLE_TESTING (`#10
<https://github.com/ros/class_loader/issues/10>`_)
* fix find Poco to return full lib path (`#8
<https://github.com/ros/class_loader/issues/8>`_)
* add missing runtime destination for library under Windows
* add Boosst component system

0.2.1 (2013-06-06)
------------------
* improve check for Poco foundation and headers (`#7
<https://github.com/ros/class_loader/issues/7>`_)

0.2.0 (2013-03-13)
------------------
* use find_package for Poco/dl instead to make it work on other platforms
* update Poco cmake file to include libdl on non-windows systems
* No longer CATKIN_DEPEND on console_bridge

Remove useless patches that have been fixed upstream
nuclearsandwich pushed a commit to nuclearsandwich/class_loader that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants