Updated class_loader QD #152
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
|
||
| ### Direct Runtime ROS Dependencies [5.i]/[5.ii] | ||
|
|
||
| - console_bridge_vendor | ||
| - rcpputils | ||
| #### `console_bridge_vendor` |
There was a problem hiding this comment.
@ahcorde meta: I'm a bit confused here, why do we depend on both the vendored package and the system dependency?
There was a problem hiding this comment.
These are the run dependencies that are in the package.xml. yo system may work with the vendored or the system dependency. The QD need to include both
There was a problem hiding this comment.
Right, the point being that the vendored package will (should?) take care of that fallback behavior, no?
There was a problem hiding this comment.
In other packages such as for example rcl_yaml_param_parser we also define both dependencies
There was a problem hiding this comment.
You need to depend on both, if console_bridge doesn't exist then the vendor package will build it. I think this vendor package is only used for this. Then you need to depend on console_bridge to use the dependency.
Signed-off-by: ahcorde <ahcorde@gmail.com>
Updated class_loader QD
Signed-off-by: ahcorde ahcorde@gmail.com