Make FrequencyStatus' name configurable #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please! 👍 |
|
Unfortunately, adding an argument to a method is an ABI-breaking change and would require that this only go into future ROS releases. If you restructure this as a new constructor that takes two arguments, it won't break ABI and will be releasable for current versions of ROS. |
NilsHaukeBussas-TomTom
force-pushed
the
frequency_status_name
branch
from
6657555
to
f7224d1
Compare
|
I don't want to pressure you, just want to make sure you notice my changes: I updated the patch by amending the commit because it's not additional work but replaces the old implementation. I've been told this might not have triggered a message to you. So, if it didn't, here's the reminder. |
|
Looks good! Thanks for the notification; github isn't good about sending notifications on code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is pretty self-explanatory. In some cases you'd like to give the frequency status some other name. This ought to be supported.