Custom names for FrequencyStatus and TimeStampStatus #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trainman419
requested changes
Aug 18, 2018
trainman419
reviewed
Aug 18, 2018
| clear(); | ||
| } | ||
| FrequencyStatus(const FrequencyStatusParam ¶ms) : | ||
| FrequencyStatus(params, "Frequency Status") {} |
There was a problem hiding this comment.
While this is convenient, delegating constructors is a C++11 feature, and this package is still supporting Indigo which only supports C++03.
| */ | ||
|
|
||
| TimeStampStatus(const TimeStampStatusParam ¶ms) : | ||
| TimeStampStatus(params, "Timestamp Status") {} |
There was a problem hiding this comment.
Same here, delegating constructors is a C++11 feature, and this package is still supporting Indigo which only supports C++03.
|
Wasn't aware of the C++03 requirement, thanks for pointing that out! All fixed now. |
trainman419
approved these changes
Aug 19, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded on #84 to allow custom names for both of the provided diagnostic tasks (FrequencyStatus and TimeStampStatus). Also provided the same functionality for the python API.
Looks like my editor caught some trailing white space. Let me know if you'd like those differences removed.