Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use system for generated configs #182

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

knorth55
Copy link
Contributor

@knorth55 knorth55 commented Aug 20, 2021

This is a backport of #152 to noetic branch.

This PR fixes the issue introduced in #140.

with #140, generated messages are inluded as SYSTEM, -isystem.
however this means that if /opt/ros/noetic/include is included with -I, compiler uses /opt/ros/noetic/include one.
this issue causes build error when we install same package both with debian package and workspace.
Now noetic-devel branch uses /opt/ros/noetic/include instead of devel/.private/<package name>/include because of -isystem.
therefore, I move back to previous one -I to fix this issue with this PR.

Related #152

@knorth55 knorth55 changed the title do not use system for generated messages or configs do not use system for generated configs Aug 20, 2021
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/dynamic-reconfigure-maintenance/21950/1

@k-okada
Copy link
Contributor

k-okada commented Dec 31, 2021

@mjcarroll Could you release this as 1.7.2 into noetic? Thanks in advance.

@seebq
Copy link

seebq commented Feb 15, 2022

Ran into this bug on our production field units that have system installed packages with messages via debian packages, and a local workspace.

Adding generate_dynamic_reconfigure_options macro makes our build look for the system installed Debians over the local workspace, resulting in build errors.

This fix confirms fixing. I saw we just did a small noetic release but this wasn't included. I also noticed this isn't on the bloom-release system (i.e. no -release repo). How can we assist in getting this into 1.7.2 into noetic?

CC @kakaday22 at Greenzie .

@gbiggs
Copy link
Contributor

gbiggs commented Feb 19, 2022

1.7.2 has been released. Look for it in the next sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants