Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rostest in CMakeLists optional (ros/rosdistro#3010) #58

Merged
merged 1 commit into from Feb 27, 2014

Conversation

bulwahn
Copy link
Contributor

@bulwahn bulwahn commented Feb 27, 2014

I was unsure if I should add this commit to hydro-devel and/or indigo-devel. So for the moment, I just added this patch to the indigo-devel branch.

tfoote added a commit that referenced this pull request Feb 27, 2014
@tfoote tfoote merged commit 651bc8c into ros:indigo-devel Feb 27, 2014
@tfoote
Copy link
Member

tfoote commented Feb 27, 2014

Indigo is good. Lets confirm it works there, and then we can cherry-pick it back.

@bulwahn
Copy link
Contributor Author

bulwahn commented Feb 28, 2014

I have seen that geometry on jenkins fails due to this commit, however I do not have access to the concret error messages/console output. Maybe this is a good time to get a jenkins account there?

@dirk-thomas
Copy link
Member

I can't confirm that. The jobs are referenced from the wiki and all are fine (except a failing unit test which is unrelated). Especially only the devel job is relevant since the change has not yet been released yet: http://wiki.ros.org/geometry?distro=indigo

And even without being logged in to Jenkins you can view all build logs, e.g.: http://jenkins.ros.org/job/devel-indigo-geometry/ARCH_PARAM=amd64,UBUNTU_PARAM=trusty,label=devel/15/consoleFull

@tfoote
Copy link
Member

tfoote commented Feb 28, 2014

The unit tests were passing before this commit. I'll take a look at it
tomorrow. You don't need an account to see the console output. On any
specific job instance click the Console Output link. For the devel job you
need to click on the architecture specific build. It's a matrix build, but
only configured for one arch.

On Thu, Feb 27, 2014 at 10:02 PM, Dirk Thomas notifications@github.comwrote:

I can't confirm that. The jobs a referenced from the wiki and all are fine
(except a failing unit test which is unrelated):
http://wiki.ros.org/geometry?distro=indigo

Reply to this email directly or view it on GitHubhttps://github.com//pull/58#issuecomment-36324331
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants