Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_frame_id of geometry_msgs::TransformStamped& t_out is not set in doTransform() #481

Open
sayali-purdue opened this issue Sep 1, 2020 · 0 comments

Comments

@sayali-purdue
Copy link

The following function on line 938 in tf2_geometry_msgs.h outputs frame transform t_out by applying transform on input transform t_in.
void doTransform(const geometry_msgs::TransformStamped& t_in, geometry_msgs::TransformStamped& t_out, const geometry_msgs::TransformStamped& transform)

The output represents the transform, and therefore, by definition it should indicate both frame_id and child_frame_id of the transform. However, the function only sets the frame_id equal to transform.header.frame_id. I think, it should also set its child_frame_id equal to t_in.child_frame_id.

Can you please confirm if my above understanding is reasonable? If not, I would really appreciate if you could explain why child_frame_id is not required.

Thank you!

ooeygui pushed a commit to ms-iot/geometry2 that referenced this issue Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant