Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate std::bind calls to lambda expressions #76

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

FelipeGdM
Copy link

This PR is a follow up to the changes made in the documentation ros2/ros2_documentation#4041

The migration of std::bind calls made in the docs is reflected here

Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two changes to pass linters, then this is probably good to go.

turtle_tf2_cpp/src/turtle_tf2_broadcaster.cpp Outdated Show resolved Hide resolved
turtle_tf2_cpp/src/turtle_tf2_broadcaster.cpp Outdated Show resolved Hide resolved
FelipeGdM and others added 2 commits January 8, 2024 11:05
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more linter error (not sure why this didn't show up in the earlier run).

turtle_tf2_cpp/src/turtle_tf2_listener.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-01-08T15:02:27.9197222Z 7: --- src/turtle_tf2_listener.cpp
2024-01-08T15:02:27.9197566Z 7: +++ src/turtle_tf2_listener.cpp.uncrustify
2024-01-08T15:02:27.9197935Z 7: @@ -56 +56 @@
2024-01-08T15:02:27.9198266Z 7: -      1s, [this](){return this->on_timer();});
2024-01-08T15:02:27.9198687Z 7: +      1s, [this]() {return this->on_timer();});

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
@FelipeGdM
Copy link
Author

I executed ament_uncrustify src/ locally to be sure all format errors are solved >.<

@ahcorde ahcorde merged commit 6481e8f into ros:ros2 Jan 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants