Only update one joint slider on value changed. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the issue raised in #5. The basic problem is that update_sliders() changes the values of the sliders, which causes the "onValueChanged" signal to be emitted for each slider. The problem is that both update_sliders() and onValueChanged() iterate over the entire list of joints, so onValueChanged() is re-evaluating all sliders during each setValue() in the update_sliders() loop. To avoid this problem, change onValueChanged() to only operate on the field that actually changed, which is accomplished with a lambda. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
approved these changes
Jan 15, 2019
|
Thanks. I'm going to merge since it seems to work in my testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue raised in
#5. The
basic problem is that update_sliders() changes the values
of the sliders, which causes the "onValueChanged" signal
to be emitted for each slider. The problem is that both
update_sliders() and onValueChanged() iterate over the
entire list of joints, so onValueChanged() is re-evaluating
all sliders during each setValue() in the update_sliders()
loop. To avoid this problem, change onValueChanged() to
only operate on the field that actually changed, which is
accomplished with a lambda.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org