Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Noetic] GUI Title contains node name #40

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 10, 2020

Replaces #26

jsp_noetic_title

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but its not blocking. I'll approve and leave it to @sloretz on whether he wants to fix that particular issue.

Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org>
@sloretz sloretz merged commit 5a9b67c into noetic-devel Mar 11, 2020
@sloretz sloretz deleted the noetic/gui_title_node_name branch March 11, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants