Remove unused find_library call #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing with Windows debug: |
sloretz
approved these changes
Jul 21, 2020
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
force-pushed
the
windows_debug_fix
branch
from
264c6da
to
56b65b2
Compare
sloretz
approved these changes
Jul 21, 2020
|
Windows debug : |
mjcarroll
changed the title
|
nuclearsandwich
approved these changes
Jul 21, 2020
mjcarroll
added a commit
that referenced
this pull request
Jul 21, 2020
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
added a commit
that referenced
this pull request
Jul 21, 2020
|
Looks like we need this patch for Foxy builds to succeed. Maybe the same for Eloquent and/or Dashing? |
|
I've made a patch release and fast-forwarded the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address recent failures in the nightly Windows debug builds.
It is likely related to a recent version upgrade in CMake, which is now 3.18.0 in Chocolatey.
Signed-off-by: Michael Carroll michael@openrobotics.org