Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodelet manager fails to recover if a nodelet throws an exception in init #13

Closed
mitchellwills opened this issue Feb 16, 2014 · 0 comments · Fixed by #21
Closed

nodelet manager fails to recover if a nodelet throws an exception in init #13

mitchellwills opened this issue Feb 16, 2014 · 0 comments · Fixed by #21
Assignees
@esteve
Labels
bug

Comments

@mitchellwills
Copy link

If an exception is throw while a nodelet is initializing the ManagedNodelet is left in the nodelet map preventing it from being fully destroyed. This also prevents a nodelet with the same name from being loading into the manger without restarting the manager
@esteve esteve added the bug label Feb 17, 2014
@esteve esteve self-assigned this May 20, 2014
esteve added a commit that referenced this issue Jun 12, 2014
@esteve
Added failing test for #13
237a98d
esteve added a commit that referenced this issue Jun 12, 2014
@esteve
Added failing test for #13
6332794
esteve added a commit that referenced this issue Jun 12, 2014
@esteve
Added failing test for #13
e77f6c4
@esteve esteve mentioned this issue Jun 12, 2014
Merged
esteve added a commit that referenced this issue Jun 16, 2014
@esteve
Merge pull request #21 from ros/nodelet-recover
4dd2db2 
Unload nodelets if they fail to initialize

Fixes #13
esteve added a commit that referenced this issue Jun 16, 2014
@esteve
Merge pull request #21 from ros/nodelet-recover
b9bea43 
Unload nodelets if they fail to initialize

Fixes #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esteve esteve

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nodelet recover ros/nodelet_core
2 participants
@esteve @mitchellwills