Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show pkg and manifest file with verbose option #59

Merged
merged 5 commits into from
Apr 11, 2017
Merged

Show pkg and manifest file with verbose option #59

merged 5 commits into from
Apr 11, 2017

Conversation

wkentaro
Copy link
Contributor

@wkentaro wkentaro commented Apr 10, 2017 •
edited
Loading

  • scripts/declared_nodelets
% rosrun nodelet declared_nodelets --verbose  # show in yaml format
- package: test_nodelet_topic_tools
  manifest: /home/wkentaro/Projects/jsk/src/ros/nodelet_core/test_nodelet_topic_tools/test/test_nodelets.xml
  nodelets:
    - test_nodelet_topic_tools/NodeletThrottleString
    - test_nodelet_topic_tools/NodeletLazyString
- package: jsk_topic_tools
  manifest: /opt/ros/indigo/share/jsk_topic_tools/jsk_topic_tools_nodelet.xml
  nodelets:
    - jsk_topic_tools/Snapshot
    - jsk_topic_tools/VitalCheckerNodelet
    - jsk_topic_tools/HzMeasure
    - jsk_topic_tools/LightweightThrottle
    - jsk_topic_tools/MUX
    - jsk_topic_tools/Relay
    - jsk_topic_tools/DeprecatedRelay
    - jsk_topic_tools/Passthrough
    - jsk_topic_tools/Block
    - jsk_topic_tools/StringRelay
- package: jsk_topic_tools
  manifest: /opt/ros/indigo/share/jsk_topic_tools/jsk_topic_tools_test_nodelet.xml
  nodelets:
    - jsk_topic_tools_test/LogUtils
...

% rosrun nodelet declared_nodelets --verbose --package test_nodelet
- package: test_nodelet
  manifest: /home/wkentaro/Projects/jsk/src/ros/nodelet_core/test_nodelet/test_nodelet.xml
  nodelets:
    - test_nodelet/Plus
    - test_nodelet/ConsoleTest
    - test_nodelet/FailingNodelet

@wkentaro wkentaro changed the title Show pkg and manifest file with verbose option [nodelet] Show pkg and manifest file with verbose option Apr 10, 2017
@wkentaro wkentaro changed the title [nodelet] Show pkg and manifest file with verbose option [nodelet] Show pkg and manifest file with verbose option + package filtering Apr 10, 2017
@wkentaro
Feature to filter with package name
802ce7d 
- scripts/declared_nodelets
@wkentaro wkentaro changed the title [nodelet] Show pkg and manifest file with verbose option + package filtering [nodelet] Option to show pkg and manifest file or package filtering Apr 10, 2017
@wkentaro wkentaro changed the title [nodelet] Option to show pkg and manifest file or package filtering [nodelet] Option to show pkg and manifest file or filter with package Apr 10, 2017
mikaelarguedas
mikaelarguedas approved these changes Apr 10, 2017
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except two minor comments, thanks @wkentaro for the contribution

nodelet/scripts/declared_nodelets Outdated

import argparse
import collections
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: is this import used anywhere ?

nodelet/scripts/declared_nodelets Outdated
for lib in dom.getElementsByTagName('library'):
for name in lib.getElementsByTagName('class'):
nodelets.append(name.getAttribute('name'))
except xml.parsers.expat.ExpatError:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to print a message to stderr here to notify users that there are some ignored manifests because unparsable?

@mikaelarguedas mikaelarguedas changed the title [nodelet] Option to show pkg and manifest file or filter with package Show pkg and manifest file with verbose option Apr 10, 2017
@mikaelarguedas
Copy link
Member

Thanks for the quick iteration

@mikaelarguedas mikaelarguedas merged commit 19def75 into ros:indigo-devel Apr 11, 2017
@wkentaro
Copy link
Contributor Author

wkentaro commented Apr 11, 2017 via email

@wkentaro wkentaro deleted the declared_nodelets_verbose branch April 11, 2017 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkentaro @mikaelarguedas