Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to configure without gtest #29

Closed
dirk-thomas opened this issue Jun 10, 2014 · 6 comments
Closed

fails to configure without gtest #29

dirk-thomas opened this issue Jun 10, 2014 · 6 comments
Assignees
Labels

Comments

@dirk-thomas
Copy link
Member

See http://answers.ros.org/question/173255/compiling-ros-to-virtual-nao/
After calling catkin_add_gtest the target can only be used if it actually exists since when the user does not have gtest no target is created.

@esteve
Copy link
Member

esteve commented Jun 10, 2014

Thanks!

@esteve
Copy link
Member

esteve commented Jun 10, 2014

That's weird, gtest is both a build and run-time dependency for catkin

@dirk-thomas
Copy link
Member Author

There are numerous reasons why this can be the case:

  • gtest removed after catkin pcakage was installed
  • gtest not installed in the first place (on platforms different then Debian)
  • ...

So the CMake code should handle this more graceful.

@vrabaud
Copy link
Member

vrabaud commented Jun 10, 2014

the weird thing is those instructions worked for us: really, maybe gtest is not part of that VM

@vrabaud
Copy link
Member

vrabaud commented Jun 11, 2014

According to the question, gtest was simply not installed. Not sure if you want to close that bug.

@esteve
Copy link
Member

esteve commented Jun 11, 2014

I've been trying to get ROS installed onto the OpenNAO VM. I updated the wiki with some fixes, but I couldn't get past the rosdep step. Are there any more up to date instructions somewhere? In any case, I'm going add a check for gtest in CMakeLists.txt and skip the test if it's missing, and close this ticket.

@esteve esteve closed this as completed in 06d315b Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants