-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depend on curl (libcurl-dev, curl) for packaging #25
Conversation
…l-dev, libcurl3) for packaging
I'm holding this for now as the new rosdep rule pointing to the virtual package |
Since that issue affects us whether we have the dependency here or patched in via the release repository we need to figure it out. The potential solutions I can see in order of most effective to most expedient are
|
ros/rosdistro#15308 has been reverted. This key now points to Merging this patch |
…20969) Increasing version of package(s) in repository `resource_retriever` to `2.1.0-1`: - upstream repository: https://github.com/ros/resource_retriever.git - release repository: https://github.com/ros2-gbp/resource_retriever-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `null` ## libcurl_vendor ``` * depend on curl (mapping to curl, libcurl4-openssl-dev) for packaging (#25 <ros/resource_retriever#25>) * add missing dependency on pkg-config (#19 <ros/resource_retriever#19>) * [libcurl_vendor] convert to ament and setup env hooks for library paths (#14 <ros/resource_retriever#14>) * Contributors: Dirk Thomas, Mikael Arguedas, William Woodall ``` ## resource_retriever ``` * Make sure to export the include directory for resource_retriever. (#22 <ros/resource_retriever#22>) * Contributors: Chris Lalancette ```
…os#20969) Increasing version of package(s) in repository `resource_retriever` to `2.1.0-1`: - upstream repository: https://github.com/ros/resource_retriever.git - release repository: https://github.com/ros2-gbp/resource_retriever-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `null` ## libcurl_vendor ``` * depend on curl (mapping to curl, libcurl4-openssl-dev) for packaging (ros#25 <ros/resource_retriever#25>) * add missing dependency on pkg-config (ros#19 <ros/resource_retriever#19>) * [libcurl_vendor] convert to ament and setup env hooks for library paths (ros#14 <ros/resource_retriever#14>) * Contributors: Dirk Thomas, Mikael Arguedas, William Woodall ``` ## resource_retriever ``` * Make sure to export the include directory for resource_retriever. (ros#22 <ros/resource_retriever#22>) * Contributors: Chris Lalancette ```
Defining the dependency on
curl
allows us to not build it from source but just depend on the upstream version.Copied from: https://github.com/ros2-gbp/resource_retriever-release/tree/5597bf018cfe1bcf3e323c50801bb89c946e9061/ubuntu/libcurl_vendor
The key resolves to
libcurl-dev
andcurl
:https://github.com/ros/rosdistro/blob/f236f31615f7eb1667e94cba66f212ddcb80829b/rosdep/base.yaml#L524
@nuclearsandwich @wjwwood @clalancette FYI