Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split curl dependency to avoid dev package at runtime #67

Merged
merged 1 commit into from Dec 4, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 30, 2021

The rosdep keys were (recently) added in ros/rosdistro#31301.

From what I can tell, the curl headers are not needed by packages building against this package, so libcurl-dev doesn't need to be a build_export_depend.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. We should also probably port this over to the ros2 branch as well.

@cottsay
Copy link
Member Author

cottsay commented Dec 4, 2021

We should also probably port this over to the ros2 branch as well.

In ROS 2, we're using libcurl_vendor, so this change doesn't apply there.

@cottsay
Copy link
Member Author

cottsay commented Dec 4, 2021

I tested this change by building up to resource_retriever, uninstalling libcurl4-openssl-dev, and then continuing the build up to rviz. The build was successful and ldd rviz shows that resource_retriever is linked correctly against libcurl.so.4, which is still installed. So this appears to work as intended.

@cottsay cottsay merged commit 4c7e368 into kinetic-devel Dec 4, 2021
@cottsay cottsay deleted the cottsay/libcurl-split branch December 4, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants