Export resource retriever to enable hooks. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
approved these changes
Oct 8, 2018
|
I've updated this PR to use the HAS_LIBRARY_TARGET option per this comment on a related PR rather than ament_export_libraries as all I needed was the environment hook to be set. I swapped rather than did both since I think it's reasonable to make the minimal change unless maintainers prefer otherwise. |
|
There was no reason that this didn't get merged, it just fell through the cracks. There have been no changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ament_export_librariescall to export the library and set necessary environment hooks. This package is one of a handful which installs libraries without setting an environment hook to add them to the platform library path.Connects to ros2/ros_workspace#10