Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .lib instead of .dll for curl #39

Closed
wants to merge 2 commits into from
Closed

Conversation

Karsten1987
Copy link

fixes #38

as far as I can tell it's sufficient to link against the .lib file of curl instead of .dll.

Signed-off-by: Karsten Knese karsten@openrobotics.org

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@sloretz
Copy link
Contributor

sloretz commented Apr 7, 2020

CI (build all, test packages above libcurl_vendor)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
Copy link
Author

so this won't cut it apparently. The workspace compiles correctly now, but RViz won't start due to missing .dlls :/

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987
Copy link
Author

Karsten1987 commented Apr 8, 2020

Trying again, now with both, lib and bin:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
Copy link
Author

closing in favor of #40

@Karsten1987 Karsten1987 closed this Apr 8, 2020
@Karsten1987 Karsten1987 deleted the use_lib branch April 8, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants