Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Do a few cleanup tasks in collada_urdf #183

Merged
merged 4 commits into from
Feb 1, 2017
Merged

Do a few cleanup tasks in collada_urdf #183

merged 4 commits into from
Feb 1, 2017

Conversation

clalancette
Copy link
Contributor

In particular:

  1. Fix up trailing whitespace.
  2. Convert tabs -> spaces
  3. Minor bug fix in the urdf_to_collada binary.
  4. Re-enable the unit tests. The old collada_urdf unit tests were completely commented out; this is because they were written against an older version of the API that no longer exists. This PR removes the old code, and adds a couple of new tests for the new API.

@clalancette
Style cleanup within collada_urdf.
a2b3e60 
No functional change, just style.

Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
@clalancette
Make sure to quit out of urdf_to_collada when invalid file is found.
d9488a6 
Otherwise, we'll just end up segfaulting later on.

Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
@clalancette
Re-enable one of the collada-urdf tests.
248d6c2 
In point of fact, we delete the rest of the tests because
they don't make much sense anymore.  Just enable this one
for now; we'll enable further ones in the future.

Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
@clalancette
Add in another test for collada_urdf.
8a08b4e 
Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
@clalancette clalancette merged commit 4d03177 into kinetic-devel Feb 1, 2017
@clalancette clalancette deleted the clalancette-cleanup branch February 1, 2017 21:53
@furushchev furushchev mentioned this pull request Feb 15, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @wjwwood