Publish fixed joints over tf_static by default in kinetic #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This caused things to break for me. The python API for tf doesn't seem to handle static transforms: ros/geometry#117 Maybe the default should be future dating until the python API of tf gets updated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the original commit 7d82611 (or a2c021f?) got lost during the kinetic release. The default value of the
use_tf_staticparameter used to betruein jade and from the discussion in #37 I assume it should have stayedtruefor all future releases.The erroneous commit that changed it back to
falseis 19294fb. There are several other bogus commits between 1.11.1 and 1.13.0 (394bed9...54a8523) which all together have almost no diff except for merged changelogs and appear to be leftovers from a bad rebase session at March 14 in preparation of the kinetic release. I assume most of these commits were never supposed to end up in the jade-devel and kinetic-devel branches nor in the release tags.Optional:
I also created a new merge between the last clean releases 1.11.1 and 1.12.1 into indigo and jade from February 22 as indigo-jade-merge-cleanup in my fork and merged it into the latest jade-devel and kinetic-devel branches. The only other changes beside the
use_tf_staticdefault value are some missing changelog entries for version 1.11.0 in jade and kinetic releases and some trailing spaces and removed empty lines. Feel free to pull the two devel branches over in order to document the alternative "true" history and to simplify future Git voodoo: