Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new urdf SharedPtr typedefs #59

Closed
nxdefiant opened this issue Sep 3, 2016 · 2 comments
Closed

Use new urdf SharedPtr typedefs #59

nxdefiant opened this issue Sep 3, 2016 · 2 comments
Labels

Comments

@nxdefiant
Copy link

nxdefiant commented Sep 3, 2016

Urdf has moved to a new SharedPtr type which results in a compile error:

/opt/ros/ros_catkin_ws/src/robot_state_publisher/src/joint_state_listener.cpp: In function 'int main(int, char**)':
/opt/ros/ros_catkin_ws/src/robot_state_publisher/src/joint_state_listener.cpp:164:98: error: conversion from 'std::map<std::__cxx11::basic_string<char>, std::shared_ptr<urdf::Joint> >::iterator {aka std::_Rb_tree_iterator<std::pair<const std::__cxx11::basic_string<char>, std::shared_ptr<urdf::Joint> > >}' to non-scalar type 'std::map<std::__cxx11::basic_string<char>, boost::shared_ptr<urdf::Joint> >::iterator {aka std::_Rb_tree_iterator<std::pair<const std::__cxx11::basic_string<char>, boost::shared_ptr<urdf::Joint> > >}' requested
   for(std::map< std::string, boost::shared_ptr< urdf::Joint > >::iterator i = model.joints_.begin(); i != model.joints_.end(); i++){

(3600 lines following this)

Replacing
boost::shared_ptr<urdf::JointMimic>
with
urdf::JointMimicSharedPtr

fixes this error.

@sloretz
Copy link
Contributor

sloretz commented Apr 17, 2017

Looks like this depends on the version of https://github.com/ros/urdfdom_headers. Yakkety and Zesty are using liburdfdom-headers-dev 1.0 which has moved on to c++11 shared_ptrs. This issue must be fixed for Lunar which is supporting those platforms.

@sloretz sloretz added Lunar and removed Lunar labels Apr 17, 2017
@sloretz
Copy link
Contributor

sloretz commented Apr 17, 2017

Looks likes this was fixed by #60 on Kinetic, and so is not an issue on Lunar. It is still broken on Indigo and Jade, but the platforms this will happen on are way above the supported platforms listed in REP-3.

It would be nice to get this building on Indigo on higher platforms, but unfortunately I don't see a path for that. The version of liburdfdom-headers-dev in trusty does not have urdf_model/types.h

I'll close this issue for now. Feel free to reopen if you see a path forward.

@sloretz sloretz closed this as completed Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants