adding a parameter "ignore_timestamp" #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Oct 20, 2016
|
Once I merge this, can you please update the documentation on the wiki to document this new parameter: http://wiki.ros.org/robot_state_publisher |
|
I updated the wiki. Thanks for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
very often I found the use case of "old" /joint_states published from rosbags, ignored by robot_state_publisher (by design, I know).
I have the feeling that, instead of remapping the timestamp to the present (as it is usually done), it would be more intuitive to allow robot_state_publisher to just use the last JointState received, ignoring its timestamp.
The default behaviour is the same as it was before, so users should not find any backward-compatibility problem.
Davide