don't hide error strings from the reader #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This except-and-raise pattern hides the actual error messages and leaves us with a generic string "cannot create test results..." instead. This makes it much harder to track down bugs. On the other hand the exception text "[Errno 13] Permission denied: 'foobar'" alone does not tell you that "foobar" is supposed to be the directory for the tests results. Thus I fused both exception texts. Because the error message in case of missing permissions is (given above) "Permission denied", I removed the "Please check permissions." hint.
|
Thank you for the improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at MoveIt, we currently have a nondeterministically broken travis (see moveit/moveit#311).
The issue at hand makes it harder to understand the source of the problem.
It would be great to see this improved and released soon :)
This except-and-raise pattern hides the actual error messages and leaves
us with a generic string "cannot create test results..." instead.
This makes it much harder to track down bugs.
On the other hand the exception text "[Errno 13] Permission denied: 'foobar'"
alone does not tell you that "foobar" is supposed to be the directory for the
tests results.
Thus I fused both exception texts. Because the error message in case of
missing permissions is (given above) "Permission denied", I removed the
"Please check permissions." hint.