fix for sourcing rosfish #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. I updated the ticket description to use the GitHub keyword "Fixes #261" to automatically close the referenced issue when this PR is merged. |
kenji-miyake
reviewed
Jan 6, 2021
| @@ -22,7 +22,7 @@ function _rosfind | |||
| # BSD find needs -E for extended regexp | |||
| find -E $argv | |||
| else | |||
| find $argv | |||
| find $arg | |||
There was a problem hiding this comment.
@iPaddy Excuse me, why was this changed? I believe $arg is empty here and $argv is correct.
How to confirm:
# Create directory to avoid slow `find`
mkdir tmp
cd tmp
# Shows no candidate
rosrun rviz <Tab>
# Edit `find $arg` to `find $argv`
sudo vim /opt/ros/noetic/share/rosbash/rosfish
# Correctly be complemented
rosrun rviz <Tab>
There was a problem hiding this comment.
I agree with you. I created PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
Fixed the script such that it sources in fish.
Functionality should match the intentions of the bash part.