Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return code for rospd for invalid package names (fix #30) #38

Merged
merged 1 commit into from
Oct 3, 2013
Merged

fix return code for rospd for invalid package names (fix #30) #38

merged 1 commit into from
Oct 3, 2013

Conversation

dirk-thomas
Copy link
Member

@mikepurvis @wjwwood Please review

Also cherry-pick to Groovy after merge.

@dirk-thomas dirk-thomas mentioned this pull request Oct 3, 2013
Closed
@mikepurvis
Copy link
Member

LGTM

$ source /opt/ros/hydro/setup.bash
$ source ~/ros/tools/rosbash/rosbash
$ rospd sensor_msgs
$ rospd
$ rospd foo
$ echo $?
1

dirk-thomas added a commit that referenced this pull request Oct 3, 2013
@dirk-thomas
Merge pull request #38 from ros/rospd
76f7ead 
fix return code for rospd for invalid package names (fix #30)
@dirk-thomas dirk-thomas merged commit 76f7ead into hydro-devel Oct 3, 2013
@dirk-thomas dirk-thomas deleted the rospd branch October 3, 2013 16:28
@dirk-thomas
Copy link
Member Author

Thank you for verifying that it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @mikepurvis