more Python 3 compatibility #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
previously approved these changes
Aug 15, 2019
dirk-thomas
force-pushed
the
dirk-thomas/python3compatibility-part5
branch
from
3c3f9fc
to
f89c088
Compare
dirk-thomas
force-pushed
the
dirk-thomas/python3compatibility-part5
branch
from
444ef45
to
96a80c8
Compare
sloretz
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1785.
The first commit is in a separate PR #1794 and will be removed from this one as soon as it is merged. Instead of looking at the changes toThe other PR has been merged and this branch been rebased.clients/rospy/src/rospy/core.py(which are fixing the line endings in the file) it is best to look at the actual change in f1680fd.