rosbag_storage: use find_library for abs path of crypto and gpgme libraries #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FreeBSD,
/usr/local/libis not in the default search path for the linker.This results in the error
ld: cannot find -lgpgmewhen buildingrosbag_storage, thoughlibgpgme.sois present in/usr/local/lib.The existing code sets
AES_ENCRYPT_LIBRARIESto contain the library names (cryptoandgpgme) and relies on the linker to find them.This PR uses the
find_libraryfunction to append/usr/local/libto the default linker search path and setAES_ENCRYPT_LIBRARIESto the absolute paths of thecryptoandgpgmelibraries.This is related to issue #1866.