Topic subscription scalability fix #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address a long standing issue where the `sockets_changed_` flag would never be reset causing the native poll set to be re-created everytime doing a poll.
|
FYI: @mikepurvis @dirk-thomas |
|
LGTM |
|
Ping for review |
|
Can you please describe how you tested this patch. |
|
We've been running the patch on our robots internally since 2018-01-19. |
|
Thanks for the info. Since @mikepurvis already gave his approval lets merge this. Thank you for the patch! |
dirk-thomas
pushed a commit
that referenced
this pull request
Feb 9, 2018
Address a long standing issue where the `sockets_changed_` flag would never be reset causing the native poll set to be re-created everytime doing a poll.
mpflanzer
added a commit
to mpflanzer/ros_comm
that referenced
this pull request
Apr 5, 2018
This reverts commit a0f4cc3.
guillaumeautran
added a commit
to clearpathrobotics/ros_comm
that referenced
this pull request
May 9, 2018
guillaumeautran
added a commit
to clearpathrobotics/ros_comm
that referenced
this pull request
May 9, 2018
guillaumeautran
added a commit
to clearpathrobotics/ros_comm
that referenced
this pull request
May 9, 2018
guillaumeautran
added a commit
to clearpathrobotics/ros_comm
that referenced
this pull request
May 9, 2018
mikepurvis
pushed a commit
that referenced
this pull request
May 10, 2018
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 9, 2018
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address a long standing issue where the
sockets_changed_flag would never be reset causing the native poll set to be re-created everytime doing a poll.