Fix return value on platforms where char is unsigned. #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms where char is unsigned (ARM), rosbag loops forever instead of playing normally, because readCharFromStdin() can never return EOF which is defined to be negative. This patch switches the return type from char to int, which is signed on all platforms.
Note that readCharFromStdin() is implemented on linux using getc, which returns int. It makes sense that readCharFromStdin(), which has similar return semantics, should have the same return type.
This patch fixes the following compile warning: