roslaunch option to log to both: screen and logfile #413
Conversation
|
First any PR should be against the latest development branch - currently indigo-devel. After they have been merged there they may be considered for backporting. I will add a number of comments to your commits inline. |
| if not self.output in ['log', 'screen', None]: | ||
| raise ValueError("output must be one of 'log', 'screen'") | ||
| if not self.output in ['log', 'screen', 'both', None]: | ||
| raise ValueError("output must be one of 'log', 'screen' or 'both'") |
There was a problem hiding this comment.
Line 437 (docblock) needs to be updated:
:param output: where to log output to, 'screen', 'log' or 'both', ``str``
dirk-thomas
changed the title
|
I adjusted the code based on your changes, so once we agree on the solution for the stdbuf I can issue a new PR. Since you mentioned it should be done on indigo-devel branch I will do it there, but as my system is not set up for indigo but for hydro I can't directly test it. Do you think the changes between indigo and hydro in respect to roslaunch are big or is it enough if I test it on hydro? |
|
You should be able to compile the indigo-devel branch just the same way as the hydro-devel branch together with all the other hydro packages. It could be the case that you need to checkout another repos indigo-devel branch but CMake should give you a warning about wrong versions in that case / or missing packages. |
…creen and file. it uses subprocess.pipe and threading. Includes corrections from PR ros#413
Fix for issue #409
I added a new ouput value
bothwhich sends stdout and stderr to both screen and file. it uses subprocess.pipe and threading.Also includes the following fix:
on http://wiki.ros.org/roslaunch/XML/node#Attributes it says that:
If 'log', the stdout/stderr output will be sent to a log file in $ROS_HOME/log, and stderr will continue to be sent to screen.
but stderr was only sent to screen, not to logfile. now stderr will be sent to both screen and log, while stdout only goes to log.