topic_tools/scripts/transform: add --wait-for-start #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Why does this option take a time parameter? Based on the situation you described shouldn't it just be wait for ever? Even if you have an option that takes a timeout, I think it should also be possible to wait for ever. |
…xitting this script in the first time
k-okada
force-pushed
the
add_wait_for_start
branch
from
f3b7b20
to
656b75b
Compare
|
I just thought that we'd like to know if the input message is not published for some reason (wrong remap ore something) or just wait for 1st message, but yes, wait for ever is much more simple. note : old implementation -> k-okada@f3b7b20 |
|
Thank you. I have slightly modified the patch and cherry-picked it in 32edfbf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add wait-for-start option to avoid exitting this script in the first time
current implemnetation exit the scirpt if the input topic is not found, but if you start
transformwith other node in the launch file, usually it takes a few seconds to start publishing topics, sotransformnode exits in the first time, this option avoid such situation