-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[topic_tools] Abstract class to implement connection based transport #713
Conversation
ConnectionBased means the node does not subscribe unless there are any child subscribers of that node. |
3dcc9a2
to
0afccfa
Compare
I don't understand what you mean with:
Please provide a detailed description what the use case is you are trying to address, the expected behavior of the provided patch and why this should be added in the ROS core (instead of being handled in user land code). |
The patch makes use of Also The remaining class
The class embeds decisions like getting all the configuration option from ros parameters. It is not possible to e.g. pass them as argument. Regarding the naming if the class: when talking about transport connection-based as a clearly defined meaning. Therefore I think the current name is confusing - something with lazy seems to be more appropriate. Based on the above comments I am not sure if this should be integrated into |
@ros-pull-request-builder retest this please |
I will change the commit like below, is these not enough to justify this to be merged?
|
I don't think a run dependency on Python six should be added since this code has been released for a very long time without. Can you update the code to not require six? The other three options would be great. |
bc3b8b2
to
80d4463
Compare
80d4463
to
9265200
Compare
Thank you for the patch and iterating on this. I have cherry-picked the changes to the kinetic-devel branch: f8f0d38 |
Thank you!. |
No description provided.