Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually send the length byte in python 3 #759

Closed
wants to merge 4 commits into from
Closed

Actually send the length byte in python 3 #759

wants to merge 4 commits into from

Commits on Mar 1, 2016

  1. Fix typo

    @eric-wieser
    eric-wieser committed Mar 1, 2016
    Configuration menu
    Copy the full SHA
    74636d5 View commit details
    Browse the repository at this point in the history

  2. Extract duplicated line from if

    @eric-wieser
    eric-wieser committed Mar 1, 2016
    Configuration menu
    Copy the full SHA
    c1074f9 View commit details
    Browse the repository at this point in the history

  3. Use items() not keys()

    @eric-wieser
    eric-wieser committed Mar 1, 2016
    Configuration menu
    Copy the full SHA
    1f92ba3 View commit details
    Browse the repository at this point in the history

  4. Try and be python-agnostic 

    Calling `str` will mask bugs where a non-string object was passed in, and is not guaranteed to use utf8 encoding
    @eric-wieser
    eric-wieser committed Mar 1, 2016
    Configuration menu
    Copy the full SHA
    28a81e7 View commit details
    Browse the repository at this point in the history