Add a non verbose (quiet) mode for rosnode info #809
Conversation
|
@dirk-thomas This file contains a lot of trailing whitespace which my editor removed by default, but I figured I'd open another pull request for that it makes reading this particular diff pretty annoying. Do let me know if you're interested. |
| @@ -554,7 +554,7 @@ def get_node_connection_info_description(node_api, master): | |||
| raise ROSNodeIOException("Communication with node[%s] failed!"%(node_api)) | |||
| return buff | |||
|
|
|||
| def rosnode_info(node_name): | |||
| def rosnode_info(node_name, non_verbose): | |||
There was a problem hiding this comment.
Please avoid inverted logic. Either call the argument quiet or verbose.
Adding a positional argument breaks existing code. Please add the new argument as an optional keyword argument. And the default value should not change the current behavior.
|
Thanks for avoiding any whitespace changes. The are usually not being considered for merge anyway since it makes backporting changes between branches unnecessary cumbersome. |
|
thanks for the comments - fixed. |
|
Thanks for the patch and update. |
Add a non verbose (quiet) mode for rosnode info
Addresses #804
Default behavior not changed to avoid regression.