Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MessageEvent constructors which are impossible to implement #21

Merged
merged 1 commit into from
Feb 11, 2014

Conversation

dirk-thomas
Copy link
Member

Removing these constructors from public API since there it is impossible to get the connection header at this point.

@tfoote @wjwwood Please review.

@wjwwood
Copy link
Member

wjwwood commented Feb 11, 2014

I don't understand the context by which they cannot be used, but if that is the case +1, otherwise it should have had a deprecation first.

@dirk-thomas
Copy link
Member Author

The second argument of the internally called init() function are the connection headers. But since the constructor only receives the message and the message does not contain the connection headers anymore the function passes a fake empty map.

@tfoote
Copy link
Member

tfoote commented Feb 11, 2014

+1

dirk-thomas added a commit that referenced this pull request Feb 11, 2014
remove MessageEvent constructors which are impossible to implement
@dirk-thomas dirk-thomas merged commit f3869dc into indigo-devel Feb 11, 2014
@dirk-thomas dirk-thomas deleted the remove_impossible_constructors branch February 11, 2014 16:11
@dirk-thomas
Copy link
Member Author

It looks like that too much external code is relying on these constructors even if they have wrong behavior. So I will revert these changes in order to not break existing code (e84f3e8). Obviously the existing code does not care that the connection header information is just made up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants